nullish-coalescing-operator finished#195
nullish-coalescing-operator finished#195jonnathan-ls merged 22 commits intojavascript-tutorial:masterfrom
Conversation
|
|
ermogenes
changed the title
|
Hi @ermogenes would you please resolve the conflicts, or inform if you're unavailable for this PR. Thank you. |
|
@odsantos conflicts resolved. |
odsantos
left a comment
odsantos
left a comment
There was a problem hiding this comment.
Hi @ermogenes here is a files' check.
Please feel free to also comment if somewhere you disagree.
Thank you,
Osvaldo.
|
Please make the requested changes. After it, add a comment "/done". |
Ajusta ortografia Co-authored-by: Osvaldo Dias dos Santos <[email protected]>
Co-authored-by: Osvaldo Dias dos Santos <[email protected]>
Co-authored-by: Osvaldo Dias dos Santos <[email protected]>
|
/done |
There was a problem hiding this comment.
Hi @ermogenes , the translation lines for the English line 44 and ahead seem not to match. Is it possible to delete the Portuguese extra blank lines (between line 43 and 47) to remove the discrepancy? Thank you.
|
@odsantos Despite what GH shows in compare, I couldn't manage to locate the discrepancy. To me both files has the same line numbers and no extra breaks or spaces. |
|
@ermogenes Thank you. |
|
Hi @ermogenes, This PR has one approval. Thank you, |
|
Hi @ermogenes, alright? Can you equalize the repositories, resolving existing conflicts? If so, I will perform the analysis for the second review! |
|
@jonnathan-ls done |
|
Please make the requested changes. After it, add a comment "/done". |
|
/done |
|
Olá @ermogenes PR aceito, grato pela contribuição ❤️ Se conhecer outras pessoas interessadas em contribuir, sinta-se a vontade para convidá-las 😄 |
5 participants
No description provided.